[BEAM-7154] Updating Go SDK errors (Part 3 - Final)#8560
Merged
akedin merged 1 commit intoapache:masterfrom May 15, 2019
Merged
[BEAM-7154] Updating Go SDK errors (Part 3 - Final)#8560akedin merged 1 commit intoapache:masterfrom
akedin merged 1 commit intoapache:masterfrom
Conversation
Contributor
Author
|
R: @lostluck |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating standard Go error functionality (
errors.Newandfmt.Errorf) to use the newly added Beam "errors" package. This PR covers thecoresubdirectory undersdks/go/pkg/beam.I tried to keep the actual changes as straightforward as possible:
NeworErrorf. This should be functionally identical.WraporWithContextusing my best judgement. I generally usedWrapwhen the wrapped error originates from third-party code (i.e. any non-Beam package), and I tried to useWithContextotherwise.WithContextmessages make the most sense in present tense (e.g. "doing foo", "reading bar"). This means I had to adjust some messages slightly, as little as I could without losing any useful information.WithContext, to improve legibility.This is the last PR for migrating to the new errors package.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.