Skip to content

Allow Google Cloud Dataflow workflows to use ".dev" workers #860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
charlesccychen wants to merge 2 commits into from
Closed

Allow Google Cloud Dataflow workflows to use ".dev" workers #860

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
15626bf
Allow Google Cloud Dataflow workflows to use ".dev" workers
charlesccychen Aug 22, 2016
7551ce9
Fix import of "re".
charlesccychen Aug 22, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion sdks/python/apache_beam/utils/dependency.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@
import glob
import logging
import os
import re
import shutil
import tempfile

Expand Down Expand Up @@ -431,7 +432,11 @@ def get_required_container_version():
version = pkg.get_distribution(GOOGLE_PACKAGE_NAME).version
# We drop any pre/post parts of the version and we keep only the X.Y.Z
# format. For instance the 0.3.0rc2 SDK version translates into 0.3.0.
return '%s.%s.%s' % pkg.parse_version(version)._version.release
container_version = '%s.%s.%s' % pkg.parse_version(version)._version.release
# We do, however, keep the ".dev" suffix if it is present.
if re.match(r'.*\.dev[0-9]*$', version):
container_version += '.dev'
return container_version
except pkg.DistributionNotFound:
# This case covers Apache Beam end-to-end testing scenarios. All these tests
# will run with a special container version.
Expand Down