[BEAM-7367] Add Kafka clients jar as a Docker dependency #8625
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Kafka clients dependency was recently set to 'provided' which requires us to include it explicitly for the container.
3 tasks
Contributor
Author
|
Run Java_Examples_Dataflow PreCommit |
Contributor
Author
|
Verified that the container builds fine. Tests are also passing. It appears that Dataflow has to update its snapshot version of Beam: https://builds.apache.org/job/beam_PreCommit_Java_Examples_Dataflow_Commit/3177 |
Contributor
Author
|
Actually, passed fine the second time. So everything looks good. |
Contributor
|
Thanks, LGTM! |
3 tasks
pl04351820
pushed a commit
to pl04351820/beam
that referenced
this pull request
Dec 20, 2023
* Release 1.3.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Kafka clients dependency was recently set to 'provided' which requires us to
include it explicitly for the container.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.