[BEAM-5709] BeamFnControlServiceTest - use latch instead of sleep #8671
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youngoli
force-pushed
the
beam5709
branch
2 times, most recently
from
42831cc to
22bcb58
Compare
Contributor
Author
|
Run Java PreCommit |
2 similar comments
Contributor
Author
|
Run Java PreCommit |
Contributor
Author
|
Run Java PreCommit |
Contributor
Author
|
Passed on Jenkins with 1000 runs, so it looks like the flake is gone with a 5 second timeout. |
Contributor
Author
|
R: @boyuanzz |
boyuanzz
approved these changes
May 31, 2019
Contributor
boyuanzz
left a comment
boyuanzz
left a comment
There was a problem hiding this comment.
Thanks for working on this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt number 2 to fix this bug. My previous PR #8395 ended up causing this test to become flaky on Jenkins despite working locally. I tried increasing the timeout from 2 seconds to 5 seconds, and then I tested by executing the test 1000 times on Jenkins, and it seems to have worked.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.