Skip to content

Conversation

@ttanay
Copy link
Contributor

@ttanay ttanay commented May 29, 2019

This PR adds useful Reify PTransforms similar to the Java SDK.
It will make code much cleaner. Eg: #8589
Related JIRA: https://issues.apache.org/jira/browse/BEAM-7388


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- --- --- --- ---
Java Build Status Build Status Build Status Build Status
Build Status
Build Status
Build Status Build Status Build Status
Python Build Status
Build Status
--- Build Status
Build Status
Build Status --- --- ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

@ttanay
Copy link
Contributor Author

ttanay commented May 30, 2019

R: @robinyqiu
This makes use of the same Map(lambda x: x) hack

@ttanay
Copy link
Contributor Author

ttanay commented May 30, 2019

Rebased with master to resolve merge conflicts.

@pabloem
Copy link
Member

pabloem commented Jun 4, 2019

Thanks Tanay! These are great. Sorru about the delay.

@pabloem pabloem merged commit 9fdf6f7 into apache:master Jun 4, 2019
@lukecwik
Copy link
Member

lukecwik commented Jun 6, 2019

ReifyTest.test_window fails in DirectRunner due to 'assign_context.window should not be None.', filed https://issues.apache.org/jira/browse/BEAM-7499

pl04351820 pushed a commit to pl04351820/beam that referenced this pull request Dec 20, 2023
Add undocumented-but-required '/documents' to the database path.

Closes apache#8717.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants