[BEAM-6865] refactor InMemoryBagUserStateFactory to standalone class#8802
Merged
iemejia merged 1 commit intoapache:masterfrom Jun 11, 2019
Merged
[BEAM-6865] refactor InMemoryBagUserStateFactory to standalone class#8802iemejia merged 1 commit intoapache:masterfrom
iemejia merged 1 commit intoapache:masterfrom
Conversation
Contributor
|
Run Java PreCommit |
mxm
approved these changes
Jun 10, 2019
Contributor
mxm
left a comment
mxm
left a comment
There was a problem hiding this comment.
Wondering whether we should add a unit test for InMemoryBagUserStateFactory? Doesn't have to be in this PR because we have coverage through the state integration tests.
Author
Seems like a good idea, but I'm going to punt on that for now. Created BEAM-7521 |
iemejia
approved these changes
Jun 11, 2019
Member
iemejia
left a comment
iemejia
left a comment
There was a problem hiding this comment.
LGTM too. Merging without the unit tests so we can rebase the Spark Portable State PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shuffling code around as setup for stateful processing on Spark portable runner.
R: @mxm
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.