Skip to content

[BEAM-6955] Use base version component of Beam Python SDK version when choosing Dataflow container image to use. #8885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
aaltay merged 2 commits into from
Jun 19, 2019
Merged

[BEAM-6955] Use base version component of Beam Python SDK version when choosing Dataflow container image to use. #8885

aaltay merged 2 commits into from
Jun 19, 2019

Conversation

@tvalentyn
Copy link
Contributor

@tvalentyn tvalentyn commented Jun 18, 2019

When Beam SDK version is modified, for example, when current version of the SDK is a release candidate, Dataflow runner should use the base version component of the SDK, which we can parse via pkg_resources.parse_version(), for example:

>>> pkg_resources.parse_version("2.14.0").base_version
'2.14.0'
>>> pkg_resources.parse_version("2.14.0.rc1").base_version
'2.14.0'

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- Build Status --- --- Build Status
Java Build Status Build Status Build Status Build Status
Build Status
Build Status		 Build Status Build Status Build Status
Build Status
Python Build Status
Build Status		 --- Build Status
Build Status		 Build Status --- --- Build Status

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

@tvalentyn tvalentyn force-pushed the df_container_image branch from cc41426 to 29d18f4 Compare June 18, 2019 17:34
@tvalentyn
Copy link
Contributor Author

tvalentyn commented Jun 18, 2019

R: @aaltay

@tvalentyn
Copy link
Contributor Author

tvalentyn commented Jun 18, 2019

Run Python PreCommit

@tvalentyn
Copy link
Contributor Author

tvalentyn commented Jun 19, 2019

Run Python PreCommit

@tvalentyn
Copy link
Contributor Author

tvalentyn commented Jun 19, 2019

Failed unit test is a flake: https://issues.apache.org/jira/browse/BEAM-7594

@tvalentyn
Copy link
Contributor Author

tvalentyn commented Jun 19, 2019

Run Python PreCommit

@tvalentyn
Copy link
Contributor Author

tvalentyn commented Jun 19, 2019 •
edited
Loading

Precommit suite failed due to another flake: https://issues.apache.org/jira/browse/BEAM-7548

@tvalentyn
Copy link
Contributor Author

tvalentyn commented Jun 19, 2019

Run Python PreCommit

@aaltay aaltay merged commit 441b6b1 into apache:master Jun 19, 2019
@tvalentyn tvalentyn mentioned this pull request Jun 19, 2019
Closed
3 tasks
@tvalentyn tvalentyn deleted the df_container_image branch October 23, 2019 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aaltay aaltay aaltay approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tvalentyn @aaltay