Enables BigTable IT test for various test suites#8886
Enables BigTable IT test for various test suites#8886chamikaramj wants to merge 1 commit intoapache:masterfrom
Conversation
|
Run Python PostCommit |
|
cc: @tvalentyn @aaltay |
|
Run Python PostCommit |
|
Run Python PreCommit |
|
Retest this please |
| "apache_beam.io.gcp.bigquery_io_read_it_test", | ||
| "apache_beam.io.gcp.bigquery_read_it_test", | ||
| "apache_beam.io.gcp.bigquery_write_it_test", | ||
| "apache_beam.io.gcp.bigtableio_it_test", |
There was a problem hiding this comment.
there is also
Line 108 in acb1f56
|
Retest this please |
|
Run Python Postcommit |
chamikaramj
force-pushed
the
enable_bt_sink_it
branch
from
1488930 to
cd352d3
Compare
|
Run Python Postcommit |
tvalentyn
left a comment
tvalentyn
left a comment
There was a problem hiding this comment.
LGTM assuming postcommit pass.
|
Run Python Postcommit |
|
Run Portable_Python PreCommit |
|
Run Python Postcommit |
| import uuid | ||
|
|
||
| import pytz | ||
| from nose.plugins.attrib import attr |
There was a problem hiding this comment.
I think line 68 meant to call constructor of beam.PTransform (a copy-paste error from WriteToBigTable implementation?). This error is caught in Py3 test suites.
It seems strange that we need to create a new transform to write test data - why is that the case, @chamikaramj ?
There was a problem hiding this comment.
The syntax should be:
super(GenerateTestRows, self).__init__()
|
What's next on this PR? |
|
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions. |
|
This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time. |
2 participants
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.