[BEAM-7641] Collect xunit statistics for Py ITs #8952
Conversation
Affects only ITs run using run_integration_test.sh.
|
run python postcommit |
|
run seed job |
|
Run Python PostCommit |
|
Run Python Dataflow ValidatesContainer |
|
Run Python Dataflow ValidatesRunner |
|
Run Python Spark ValidatesRunner |
|
run python precommit |
|
run seed job |
1 similar comment
|
run seed job |
|
Run Python PostCommit |
|
Run Python Dataflow ValidatesContainer |
|
Run Python Dataflow ValidatesRunner |
|
run python precommit |
|
Run Python PostCommit |
|
R: @lukecwik @markflyhigh
|
|
run python precommit |
|
run python postcommit |
markflyhigh
left a comment
markflyhigh
left a comment
There was a problem hiding this comment.
Thank you for improving xunit statistics!
| # `--tests`, `--nologcapture`. More can be found in | ||
| # https://nose.readthedocs.io/en/latest/man.html#options | ||
| # suite -> Namespace for this run of tests. Required if running | ||
| # under Jenkins. |
There was a problem hiding this comment.
Can you explain more about it? It's still not clear to me what string I should give when adding new test and how it's been used from nose. Can it be an arbitrary string? Should it be unique?
There was a problem hiding this comment.
It's used to differentiate runs of the same tests with different arguments/python versions/etc.
There was a problem hiding this comment.
Added more explanation to the comment.
| echo ">>> RUNNING integration tests with pipeline options: $PIPELINE_OPTS" | ||
| echo ">>> test options: $TEST_OPTS" | ||
| # TODO(udim): Pass $SUITE once migrated to pytest. xunitmp doesn't support suite | ||
| # names. |
There was a problem hiding this comment.
Can you create a jira to track it? And maybe link to pytest epic? it's easy to forget after a while.
| @@ -48,6 +48,8 @@ | |||
| # during execution. Commonly used options like `--attr`, | |||
| # `--tests`, `--nologcapture`. More can be found in | |||
| # https://nose.readthedocs.io/en/latest/man.html#options | |||
There was a problem hiding this comment.
test_opts is defined to hold Nose configs. Do you have particular reason to define it separately?
There was a problem hiding this comment.
Yes, it is also used in the xml output filename.
|
run python postcommit |
2 similar comments
|
run python postcommit |
|
run python postcommit |
|
R: @tvalentyn could you take a look? |
|
LGTM |
Affects only ITs run using run_integration_test.sh.
Affects only ITs run using run_integration_test.sh.
3 participants
Affects only ITs run using run_integration_test.sh.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.