[BEAM-7640] Rename the package name for amazon-web-services2 from aws to aws2 #8983
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
aromanenko-dev
left a comment
aromanenko-dev
left a comment
There was a problem hiding this comment.
It's ok for me, just have a couple of questions.
...-web-services/src/main/java/org/apache/beam/sdk/io/aws/s3/DefaultS3ClientBuilderFactory.java
Outdated
Show resolved
Hide resolved
...ava/io/amazon-web-services2/src/main/java/org/apache/beam/sdk/io/aws2/options/AwsModule.java
Show resolved
Hide resolved
… to aws2 This is needed to avoid name collisions at debug time with the amazon-web-services module. Also it allows users to migrate progressively to the new module and even be able to mix both if required.
iemejia
force-pushed
the
BEAM-7640-aws2-fix-package
branch
from
afc9a35 to
88f0cef
Compare
Member
Author
|
Hi I haven't noticed I had screwed the PR because of an IntelliJ error, It should be ok now. Please re review @aromanenko-dev |
aromanenko-dev
approved these changes
Jul 2, 2019
Contributor
aromanenko-dev
left a comment
aromanenko-dev
left a comment
There was a problem hiding this comment.
LGTM, thanks
Let's wait for Jenkins being green before merging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to avoid name collisions at debug time with the
amazon-web-services module. Also it allows users to migrate
progressively to the new module and even be able to mix both if
required.
R: @aromanenko-dev