Skip to content

[BEAM-7735] Label ParDos with their name#9053

Merged
lostluck merged 1 commit intoapache:masterfrom
happygiraffe:patch-1
Jul 16, 2019
Merged

[BEAM-7735] Label ParDos with their name#9053
lostluck merged 1 commit intoapache:masterfrom
happygiraffe:patch-1

Conversation

@happygiraffe
Copy link
Contributor

@happygiraffe happygiraffe commented Jul 12, 2019

The diagram is much easier to read if individual ParDos are identifiable.

This applies to the Go SDK's dot runner. It was not previously possible to obtain the name.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- Build Status --- --- Build Status
Java Build Status Build Status Build Status Build Status
Build Status
Build Status
Build Status Build Status Build Status
Build Status
Python Build Status
Build Status
--- Build Status
Build Status
Build Status --- --- Build Status

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

The diagram is much easier to read if individual ParDos are identifiable.
@happygiraffe
Copy link
Contributor Author

R: @lostluck

@lostluck
Copy link
Contributor

Please update the PR description that this is for the Go SDK dot runner, and that previously it wasn't possible
Please prefix the PR title with [BEAM-7735] to refer to https://issues.apache.org/jira/browse/BEAM-7735 which is a subtask I've created for other Dot runner improvements.

@happygiraffe happygiraffe changed the title Label ParDos with their name [BEAM-7735] Label ParDos with their name Jul 13, 2019
@happygiraffe
Copy link
Contributor Author

Please update the PR description that this is for the Go SDK dot runner, and that previously it wasn't possible

Done.

Please prefix the PR title with [BEAM-7735] to refer to https://issues.apache.org/jira/browse/BEAM-7735 which is a subtask I've created for other Dot runner improvements.

Done.

@lostluck lostluck merged commit da45987 into apache:master Jul 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants