[BEAM-4420] KafkaIOIT metrics collection #9073
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@aromanenko-dev could you take a look? |
aromanenko-dev
requested changes
Jul 16, 2019
Contributor
aromanenko-dev
left a comment
aromanenko-dev
left a comment
There was a problem hiding this comment.
Thanks, almost LGTM, just several notes.
sdks/java/io/kafka/src/test/java/org/apache/beam/sdk/io/kafka/KafkaIOIT.java
Outdated
Show resolved
Hide resolved
sdks/java/io/kafka/src/test/java/org/apache/beam/sdk/io/kafka/KafkaIOIT.java
Outdated
Show resolved
Hide resolved
sdks/java/io/kafka/src/test/java/org/apache/beam/sdk/io/kafka/KafkaIOIT.java
Outdated
Show resolved
Hide resolved
Contributor
|
Also, do you think it would be better to squash commits into one? |
lgajowy
force-pushed
the
BEAM-4420_kafka-ioit-metrics
branch
from
948e312 to
6e6675c
Compare
Contributor
Author
|
Thanks! I posted the fixes. Could you take a look again? I also squashed the Kafka part but left out the IOITMetrics refactoring as a separate commit. I think it's a separate concern, more general one that we didn't have a way to publish already collected |
Contributor
|
Run Python_PVR_Flink PreCommit |
Contributor
|
Run JavaPortabilityApi PreCommit |
Contributor
Author
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added "TimeMonitors" and collect read, write and run time. Some minor refactoring included (in IOITMetrics.java class).
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.