[BEAM-7782] Skip DoFn params test in Python 2 on Windows #9081
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
R: @tvalentyn can you give this a look whenever you have a chance? |
tvalentyn
reviewed
Jul 17, 2019
sdks/python/apache_beam/examples/snippets/transforms/element_wise/pardo.py
Outdated
Show resolved
Hide resolved
tvalentyn
reviewed
Jul 17, 2019
sdks/python/apache_beam/examples/snippets/transforms/element_wise/pardo_test.py
Outdated
Show resolved
Hide resolved
Contributor
|
Code changes LGTM as long as tests pass. Please:
|
tvalentyn
reviewed
Jul 18, 2019
sdks/python/apache_beam/examples/snippets/transforms/element_wise/pardo_test.py
Outdated
Show resolved
Hide resolved
Contributor
|
Test failure seems unrelated. |
davidcavazos
force-pushed
the
pardo_test_fix
branch
from
4346820 to
bbaf895
Compare
Author
|
All tests passed, @tvalentyn can you take a look whenever you have a chance? |
Contributor
|
The change LGTM - could you please follow up on 1-3? |
davidcavazos
force-pushed
the
pardo_test_fix
branch
from
bbaf895 to
500c570
Compare
davidcavazos
changed the title
Author
|
Sorry, I missed to see that comment, but it's all addressed :) |
Contributor
|
@pabloem could you please help merge this? thank you! |
tvalentyn
approved these changes
Jul 18, 2019
Contributor
|
Thanks, @davidcavazos ! |
aaltay
approved these changes
Jul 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip DoFn params test in Python 2 on Windows since it uses
longinstead ofintfortimestamp.micros.Also, moving the
pylintmessages outside the region tags, and simplifying test functions setup.Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.