[BEAM-7557] Migrate DynamoDBIO to AWS SDK for Java 2#9086
Closed
cmachgodaddy wants to merge 1 commit intoapache:masterfrom
Closed
[BEAM-7557] Migrate DynamoDBIO to AWS SDK for Java 2#9086cmachgodaddy wants to merge 1 commit intoapache:masterfrom
cmachgodaddy wants to merge 1 commit intoapache:masterfrom
Conversation
3 tasks
iemejia
approved these changes
Jul 17, 2019
Member
iemejia
left a comment
iemejia
left a comment
There was a problem hiding this comment.
LGTM I will merge it manually to fix some typos and really minor stuff. Thanks a lot @cmachgodaddy for taking care of this and sorry for the slow review.
| * .withRetryConfiguration( | ||
| * DynamoDBIO.RetryConfiguration.create(5, Duration.standardMinutes(1))) | ||
| * .withAwsClientsProvider(new BasicSnsProvider(accessKey, secretKey, region)); | ||
| * .withAwsClientsProvider(new BasicDynamoDbProvider(accessKey, secretKey, region)); |
Member
There was a problem hiding this comment.
Thanks for fixing the doc on the other one!
iemejia
changed the title
Member
|
Merged! |
iemejia
added a commit
that referenced
this pull request
Jul 17, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.