[BEAM-7781] Fix Go SDK PreCommits#9103
Merged
lostluck merged 3 commits intoapache:masterfrom Jul 23, 2019
Merged
Conversation
Contributor
Author
|
Run Go PreCommit |
Contributor
Author
|
Will probably punt these changes helping get #9085 in instead, |
Contributor
Author
|
R: @youngoli |
Contributor
Author
|
Run Go PostCommit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It appears that Go 1.10 stopped working for the precommits but both Go 1.11 and Go 1.12 work. Given that Go 1.13 is releasing soon we should at least get to the current version (go 1.12)
GoGradle apparently sources the Go tool of the correct version itself, so there shouldn't be any jenkins image changes required. AFAICT Moving to a new version of the GoGradle plugin simply uses gradle magic.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.