Skip to content

[BEAM-7901] Increase default chunk size for gRPC commit and get data streams.#9256

Merged
lukecwik merged 2 commits intoapache:masterfrom
slavachernyak:commitSizes
Aug 6, 2019
Merged

[BEAM-7901] Increase default chunk size for gRPC commit and get data streams.#9256
lukecwik merged 2 commits intoapache:masterfrom
slavachernyak:commitSizes

Conversation

@slavachernyak
Copy link
Contributor

The initial choice of chunk size was arbitrary, and there is evidence from testing that larger chunks improve performance.

R: @lukecwik


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- Build Status --- --- Build Status
Java Build Status Build Status Build Status Build Status
Build Status
Build Status
Build Status Build Status Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status
--- Build Status
Build Status
Build Status --- --- Build Status

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

… initial choice of chunk size was arbitrary, and there is evidence from testing that larger chunks improve performance.
@lukecwik
Copy link
Member

lukecwik commented Aug 5, 2019

Will merge when tests are green.

@lukecwik
Copy link
Member

lukecwik commented Aug 5, 2019

Looks like there is a failing test

org.apache.beam.runners.dataflow.worker.windmill.GrpcWindmillServerTest.testStreamingGetDataHeartbeats
Error Message
java.lang.AssertionError: 
Expected: a value less than or equal to <64512>
     but: <108273> was greater than <64512>

https://builds.apache.org/job/beam_PreCommit_Java_Commit/7072/testReport/junit/org.apache.beam.runners.dataflow.worker.windmill/GrpcWindmillServerTest/testStreamingGetDataHeartbeats/

@lukecwik lukecwik merged commit 6159162 into apache:master Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants