[BEAM-7946] Changed name of sdist task in LoadTests gradle#9312
Conversation
|
Run Python Load Tests Combine Dataflow Batch |
kkucharc
force-pushed
the
BEAM-7946-fix-sdist-task-dependency
branch
from
f9e90e5 to
ba61e69
Compare
|
Run Python Load Tests Combine Dataflow Batch |
| dependsOn 'sdist' | ||
| loadTestArgs +=" --sdk_location=${project.buildDir}/apache-beam.tar.gz" | ||
| dependsOn ':sdks:python:sdist' | ||
| loadTestArgs +=" --sdk_location=${project.rootDir}/sdks/python/build/apache-beam.tar.gz" |
There was a problem hiding this comment.
I am not sure if there is variable for this dir, but buildDir points to sdks/python/apache_beam/testing/load_tests which after changes in sdist task in no more dist dir.
There was a problem hiding this comment.
Thank you for the fix! Sorry for missing this test when I did sdist change. There is a Gradle way to do that (instead building relative path): (e.g. test-suites/dataflow/py35/build.gradle)
- Declare a new dependency for this tarball file:
dependencies {
distTarBall project(path: ":sdks:python", configuration: "distTarBall")
}
- Get absolute path by
files(configurations.distTarBall.files).singleFile.
There was a problem hiding this comment.
Thank you for help :) I changed gradle according to those hints.
|
@markflyhigh Hi, can you take a look? I created also issue to move tests to test-suites but I would like bring load tests back to life first. |
|
Thank you @kkucharc! I'd also love to review your following PRs for moving this test. |
kkucharc
force-pushed
the
BEAM-7946-fix-sdist-task-dependency
branch
from
ba61e69 to
e62bb34
Compare
|
Run Python Load Tests Combine Dataflow Batch |
2 participants
Due to failing load test jobs because of problem of finding
sdisttask, a task name is changed to detailed onesdks:python:sdist.Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.