[BEAM-7882] Invoke Spark API incompatible methods by reflection#9370
Merged
iemejia merged 1 commit intoapache:masterfrom Aug 19, 2019
Merged
[BEAM-7882] Invoke Spark API incompatible methods by reflection#9370iemejia merged 1 commit intoapache:masterfrom
iemejia merged 1 commit intoapache:masterfrom
Conversation
It adds also Spark 3 specific version of the methods
Member
Author
|
Run Spark ValidatesRunner |
Member
Author
|
Run Java Spark PortableValidatesRunner Batch |
RyanSkraba
approved these changes
Aug 19, 2019
Contributor
RyanSkraba
left a comment
RyanSkraba
left a comment
There was a problem hiding this comment.
Hello! This works for me, LGTM! Reflection based on the reported Spark version (and good java comments) is probably the most maintainable way to do this.
Member
Author
|
Thanks @RyanSkraba Yes it seems like the easiest maintainable path. I hesitated between two modules but the changes are relatively small and they impact just a tiny part of the codebase to justify the effort of having separate modules +implementations. Of course we can re evaluate this in the future, the path towards two modules or to let support only for Spark 3 in the future is super straightforward because of this class. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It adds also Spark 3 specific version of the methods
R: @RyanSkraba