[BEAM-8010] Remove translation of bounded reads from portable Flink Runner #9383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unner In the course of BEAM-6730 we added a way to Runner-translate bounded and unbounded Reads in portable pipelines. However, bounded Reads are already supported via Impulse + BoundedReadViaImpulse. This can be fixed by removing the bounded read translators from portable pipelines.
Contributor
Author
|
Run Java Flink PortableValidatesRunner Streaming |
Contributor
Author
|
Run Java Flink PortableValidatesRunner Batch |
iemejia
approved these changes
Aug 21, 2019
Member
iemejia
left a comment
iemejia
left a comment
There was a problem hiding this comment.
LGTM. Really nice. Less code to maintain is always welcome!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the course of BEAM-6730 we added a way to Runner-translate bounded and
unbounded Reads in portable pipelines. However, bounded Reads are already
supported via Impulse + BoundedReadViaImpulse.
This can be fixed by removing the bounded read translators from portable
pipelines.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.