Skip to content

[BEAM-7635] Migrate SnsIO to AWS SDK for Java 2#9393

Closed
cmachgodaddy wants to merge 2 commits intoapache:masterfrom
cmachgodaddy:BEAM-7635
Closed

[BEAM-7635] Migrate SnsIO to AWS SDK for Java 2#9393
cmachgodaddy wants to merge 2 commits intoapache:masterfrom
cmachgodaddy:BEAM-7635

Conversation

@cmachgodaddy
Copy link
Contributor

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- Build Status --- --- Build Status
Java Build Status Build Status Build Status Build Status
Build Status
Build Status
Build Status Build Status Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status
--- Build Status
Build Status
Build Status --- --- Build Status
XLang --- --- --- Build Status --- --- ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

@@ -0,0 +1 @@
mock-maker-inline
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add this file extension to the RAT plugin exclusions

"**/*.json",

Copy link
Member

@iemejia iemejia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Merging manually to do a minor fix in the Coder.
Great work @cmachgodaddy

@iemejia
Copy link
Member

iemejia commented Oct 8, 2019

Closing manually since already merged. One extra comment on this one. I finally did not change the PublishResponse return type in case users in a step downstream in the Pipeline may want to use the ids to request the status of the response.

@iemejia iemejia closed this Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants