Skip to content

Conversation

@kamilwu
Copy link
Contributor

@kamilwu kamilwu commented Aug 23, 2019


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- Build Status --- --- Build Status
Java Build Status Build Status Build Status Build Status
Build Status
Build Status
Build Status Build Status Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status
--- Build Status
Build Status
Build Status --- --- Build Status
XLang --- --- --- Build Status --- --- ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

Metrics shouldn't be published for now because there is currently
no way to get them from PortableRunner's pipeline result
(see Jira issue: https://issues.apache.org/jira/browse/BEAM-4775)

We will activate this once collecting metrics is possible.
@kamilwu
Copy link
Contributor Author

kamilwu commented Aug 23, 2019

R: @lgajowy Please take a look. I extracted this commit from the following PR (#9213) just as you had suggested.

Copy link
Contributor

@lgajowy lgajowy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@lgajowy lgajowy merged commit dc63296 into apache:master Aug 23, 2019
@kamilwu kamilwu deleted the turn-off-metrics-publication-on-flink branch August 24, 2019 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants