[BEAM-7389] Update to use util.ToString transform #9433
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
davidcavazos
force-pushed
the
tostring-sample
branch
2 times, most recently
from
626246b to
5923e32
Compare
Member
|
LGTM, could you fix the test issues? |
Author
|
I'm on it. It's some weird behavior with the |
davidcavazos
force-pushed
the
tostring-sample
branch
2 times, most recently
from
f9998f9 to
a08c3cc
Compare
Author
|
@aaltay Tests are passing, ready for review. I had to do some workarounds due to discrepancies in which |
aaltay
reviewed
Aug 29, 2019
sdks/python/apache_beam/examples/snippets/transforms/element_wise/to_string_test.py
Show resolved
Hide resolved
davidcavazos
force-pushed
the
tostring-sample
branch
from
a08c3cc to
0c61e3c
Compare
aaltay
approved these changes
Aug 31, 2019
Member
|
@davidcavazos for future PRs, could you keep adding new commits instead of squashing and force pushing. Reviewing deltas are much easier that way. Before merging I/you one of us can do the squashing. |
Author
|
Got it, will do that from here on now :) Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the code sample for
ToStringto use the util.ToString transform.R: @aaltay Can you take a look whenever you have a chance? Thanks!
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.