Skip to content

[BEAM-8105] update release guide with docker images #9510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
markflyhigh merged 5 commits into from
Sep 17, 2019
Merged

[BEAM-8105] update release guide with docker images #9510

markflyhigh merged 5 commits into from
Sep 17, 2019

Conversation

@Hannah-Jiang
Copy link
Contributor

@Hannah-Jiang Hannah-Jiang commented Sep 6, 2019 •
edited
Loading

This PR is adding release procedure for docker images.

Publishing docker images as part of release is tackled with following three PRs.

Change default image name. (#9487 )
Add staging and publishing scripts for docker images to release procedure. (#9506)
Updating release-guide.md (current PR, #9510)

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- Build Status --- --- Build Status
Java Build Status Build Status Build Status Build Status
Build Status
Build Status		 Build Status Build Status Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status		 --- Build Status
Build Status		 Build Status --- --- Build Status
XLang --- --- --- Build Status --- --- ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

@Hannah-Jiang Hannah-Jiang mentioned this pull request Sep 6, 2019
Merged
3 tasks
@Hannah-Jiang
Copy link
Contributor Author

Hannah-Jiang commented Sep 6, 2019 •
edited
Loading

Though it's WIP, I would like to give you a heads up about PR size. @soyrice

@Hannah-Jiang Hannah-Jiang mentioned this pull request Sep 7, 2019
Merged
3 tasks
@Hannah-Jiang Hannah-Jiang changed the title [WIP][BEAM-8105] update release guide with docker images [BEAM-8105] update release guide with docker images Sep 10, 2019
@Hannah-Jiang
Copy link
Contributor Author

Hannah-Jiang commented Sep 10, 2019

R: @soyrice
Cc: @markflyhigh , @yifanzou

@markflyhigh
Copy link
Contributor

markflyhigh commented Sep 10, 2019

Note: preview this change in http://apache-beam-website-pull-requests.storage.googleapis.com/9510/contribute/release-guide/index.html

markflyhigh
markflyhigh requested changes Sep 10, 2019
View reviewed changes
@Hannah-Jiang
Copy link
Contributor Author

Hannah-Jiang commented Sep 10, 2019 •
edited
Loading

@markflyhigh , I addressed all your comments, PTAL.

soyrice
soyrice suggested changes Sep 11, 2019
View reviewed changes
markflyhigh
markflyhigh reviewed Sep 11, 2019
View reviewed changes
Copy link
Contributor

@markflyhigh markflyhigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Would you like to help with 2.16 release on docker part? We can try this process in 2.16 and finalize it.

@Hannah-Jiang
Copy link
Contributor Author

Hannah-Jiang commented Sep 11, 2019

Thank you. Would you like to help with 2.16 release on docker part? We can try this process in 2.16 and finalize it.

Yes, of course!

@Hannah-Jiang
Copy link
Contributor Author

Hannah-Jiang commented Sep 11, 2019

@soyrice I addressed your comments, PTAL.
@markflyhigh , your comments were addressed at the same commit. PTAL.

@soyrice
Copy link
Contributor

soyrice commented Sep 12, 2019

@soyrice I addressed your comments, PTAL.
@markflyhigh , your comments were addressed at the same commit. PTAL.

LGTM!

markflyhigh
markflyhigh reviewed Sep 12, 2019
View reviewed changes
markflyhigh
markflyhigh approved these changes Sep 12, 2019
View reviewed changes
Copy link
Contributor

@markflyhigh markflyhigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM in general.

@markflyhigh markflyhigh self-requested a review September 12, 2019 21:57
@markflyhigh
Copy link
Contributor

markflyhigh commented Sep 12, 2019 •
edited
Loading

Can you also update this section Change and commit version number in release branch: to include gradle.properties? This is how release manager verify changes after run cut_release_branch.sh

markflyhigh
markflyhigh reviewed Sep 16, 2019
View reviewed changes
website/src/contribute/release-guide.md
Verify that files are [present](https://dist.apache.org/repos/dist/dev/beam).

#### Stage SDK images on hub.docker.com
* Build Python images and push to DockerHub.
Copy link
Contributor

@markflyhigh markflyhigh Sep 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The format seems not correct on staging page: http://apache-beam-website-pull-requests.storage.googleapis.com/9510/contribute/release-guide/index.html#alternative-run-all-steps-manually-1. Can you fix it?

Copy link
Contributor Author

@Hannah-Jiang Hannah-Jiang Sep 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is fixed.

@Hannah-Jiang
Copy link
Contributor Author

Hannah-Jiang commented Sep 16, 2019

Can you also update this section Change and commit version number in release branch: to include gradle.properties? This is how release manager verify changes after run cut_release_branch.sh

This is added.

@Hannah-Jiang
Copy link
Contributor Author

Hannah-Jiang commented Sep 16, 2019

Run Java PreCommit

@Hannah-Jiang
Copy link
Contributor Author

Hannah-Jiang commented Sep 17, 2019

Run Portable_Python PreCommit

@markflyhigh
Copy link
Contributor

markflyhigh commented Sep 17, 2019

LGTM

@markflyhigh markflyhigh merged commit 6d56040 into apache:master Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markflyhigh markflyhigh markflyhigh approved these changes

+1 more reviewer

@soyrice soyrice soyrice requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Hannah-Jiang @markflyhigh @soyrice