[BEAM-8226] Alter getInputElementsConsumed computation for monitoring…#9571
Merged
Ardagan merged 1 commit intoapache:masterfrom Sep 14, 2019
Merged
[BEAM-8226] Alter getInputElementsConsumed computation for monitoring…#9571Ardagan merged 1 commit intoapache:masterfrom
Ardagan merged 1 commit intoapache:masterfrom
Conversation
y1chi
force-pushed
the
consumed_elements
branch
3 times, most recently
from
284217a to
0219654
Compare
…Infos in RegisterAndProcessBundleOperation.java
y1chi
force-pushed
the
consumed_elements
branch
from
0219654 to
d41bb5b
Compare
Author
|
Run Java PreCommit |
Author
|
Not entirely sure this is correct fix but it seems to give us more consistent count numbers between legacy metrics and the new ones. Mikhail could you take a look, whether this makes sense at all? Or explain a little bit why the condition was |
Ardagan
approved these changes
Sep 14, 2019
Contributor
Ardagan
left a comment
Ardagan
left a comment
There was a problem hiding this comment.
That is a valid fix for typo.
Author
Thanks. |
Member
|
Should this be cherry picked to the release branch? /cc @markflyhigh |
y1chi
pushed a commit
to y1chi/beam
that referenced
this pull request
Sep 16, 2019
…Infos in RegisterAndProcessBundleOperation.java (apache#9571)
3 tasks
Contributor
|
This would be worth cherry picking.
…On Mon, Sep 16, 2019, 10:29 Ahmet Altay ***@***.***> wrote:
Should this be cherry picked to the release branch?
/cc @markflyhigh <https://github.com/markflyhigh>
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#9571?email_source=notifications&email_token=ADAEZBRN2GVQGFQ45IR77DTQJ6657A5CNFSM4IWTTCM2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6Z4YAA#issuecomment-531876864>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADAEZBUPZO6AZHNYDORQSXTQJ6657ANCNFSM4IWTTCMQ>
.
|
soyrice
pushed a commit
to soyrice/beam
that referenced
this pull request
Sep 19, 2019
…Infos in RegisterAndProcessBundleOperation.java (apache#9571)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…Infos in RegisterAndProcessBundleOperation.java
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.