Skip to content

[BEAM-8093] Commit change to ensure py36-gcp runs tests#9592

Merged
lukecwik merged 1 commit intoapache:masterfrom
lukecwik:beam8093
Sep 17, 2019
Merged

[BEAM-8093] Commit change to ensure py36-gcp runs tests#9592
lukecwik merged 1 commit intoapache:masterfrom
lukecwik:beam8093

Conversation

@lukecwik
Copy link
Member

This is a temporary solution while waiting for full solution in #7949


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- Build Status --- --- Build Status
Java Build Status Build Status Build Status Build Status
Build Status
Build Status
Build Status Build Status Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status
--- Build Status
Build Status
Build Status --- --- Build Status
XLang --- --- --- Build Status --- --- ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

This is a temporary solution while waiting for full solution in apache#7949
@lukecwik
Copy link
Member Author

R: @udim
CC: @robertwb @tvalentyn

@lukecwik
Copy link
Member Author

I ran into this while attempting to debug a test failure and was wondering why py36 was passing yet py35 and py37 failed.

Copy link
Contributor

@robertwb robertwb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably be using https://tox.readthedocs.io/en/latest/example/basic.html#compressing-dependency-matrix to avoid these kinds of omissions.

@lukecwik
Copy link
Member Author

I think the improvement comments should really be on #7949 since that is a much more substantive clean-up change.

@udim
Copy link
Member

udim commented Sep 17, 2019

We should probably be using https://tox.readthedocs.io/en/latest/example/basic.html#compressing-dependency-matrix to avoid these kinds of omissions.

The environment is defined but has no command. I added a default failing command in #9593 .

@tvalentyn
Copy link
Contributor

Thanks, @lukecwik. I incorrectly used Affects Version label instead of Fix Version for BEAM-8093, and it fell off my radar.

@lukecwik lukecwik merged commit 2e59c27 into apache:master Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants