[BEAM-8093] Commit change to ensure py36-gcp runs tests#9592
Merged
lukecwik merged 1 commit intoapache:masterfrom Sep 17, 2019
Merged
[BEAM-8093] Commit change to ensure py36-gcp runs tests#9592lukecwik merged 1 commit intoapache:masterfrom
lukecwik merged 1 commit intoapache:masterfrom
Conversation
This is a temporary solution while waiting for full solution in apache#7949
Member
Author
|
R: @udim |
Member
Author
|
I ran into this while attempting to debug a test failure and was wondering why py36 was passing yet py35 and py37 failed. |
robertwb
approved these changes
Sep 17, 2019
Contributor
robertwb
left a comment
There was a problem hiding this comment.
We should probably be using https://tox.readthedocs.io/en/latest/example/basic.html#compressing-dependency-matrix to avoid these kinds of omissions.
robertwb
approved these changes
Sep 17, 2019
Member
Author
|
I think the improvement comments should really be on #7949 since that is a much more substantive clean-up change. |
udim
approved these changes
Sep 17, 2019
3 tasks
3 tasks
Member
The environment is defined but has no |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a temporary solution while waiting for full solution in #7949
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.