-
Notifications
You must be signed in to change notification settings - Fork 4.5k
[BEAM-7389] Created elementwise for consistency with docs #9664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
407e4d9 to
f92412a
Compare
aaltay
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you update the docs, and delete obsolete files all in a single change?
|
Yes, will do. Thanks! |
|
Updated docs and obsolete files deleted in #9692, but they won't render correctly until this one is merged. |
|
As per this plan, I will be moving code files from |
|
Is this ready to review? |
f92412a to
c0b3fda
Compare
|
It is now ready for review. No changes to logic I did take the time to normalize all the code files to use relative imports as well as moving the asserts to |
|
I do not see any deleted files or doc changes. Am I missing something? |
|
That would break the staged versions and the notebooks would have to be generated in a second pass anyways. I'm doing that here #9692, that way we don't temporarily break things in the website. |
|
OK. Merged this, please do the clean up as soon as possible. |
No logic changes, only filename and region tag changes.
Changing some python filenames to match the docs filenames for consistency.
Will delete the old files as the docs get updated.
R: @aaltay
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.