Skip to content

Conversation

@davidcavazos
Copy link

@davidcavazos davidcavazos commented Sep 25, 2019

No logic changes, only filename and region tag changes.

Changing some python filenames to match the docs filenames for consistency.

Will delete the old files as the docs get updated.

R: @aaltay


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- Build Status --- --- Build Status
Java Build Status Build Status Build Status Build Status
Build Status
Build Status
Build Status Build Status Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status
--- Build Status
Build Status
Build Status --- --- Build Status
XLang --- --- --- Build Status --- --- ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

@davidcavazos davidcavazos changed the title [BEAM-7389] Normalized filename to match doc filenames [BEAM-7389] Created code files to match doc filenames Sep 25, 2019
Copy link
Member

@aaltay aaltay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update the docs, and delete obsolete files all in a single change?

@davidcavazos
Copy link
Author

Yes, will do. Thanks!

@davidcavazos
Copy link
Author

Updated docs and obsolete files deleted in #9692, but they won't render correctly until this one is merged.

@davidcavazos
Copy link
Author

As per this plan, I will be moving code files from element-wise to elementwise for consistency.

@aaltay
Copy link
Member

aaltay commented Oct 3, 2019

Is this ready to review?

@davidcavazos davidcavazos changed the title [BEAM-7389] Created code files to match doc filenames [BEAM-7389] Created elementwise for consistency with docs Oct 3, 2019
@davidcavazos
Copy link
Author

It is now ready for review.

No changes to logic

I did take the time to normalize all the code files to use relative imports as well as moving the asserts to check_ functions for consistency in the test files. Other than that, there are no changes from the element_wise counterparts besides the small changes to make linter and all tests pass.

@aaltay
Copy link
Member

aaltay commented Oct 4, 2019

I do not see any deleted files or doc changes. Am I missing something?

@davidcavazos
Copy link
Author

That would break the staged versions and the notebooks would have to be generated in a second pass anyways. I'm doing that here #9692, that way we don't temporarily break things in the website.

@aaltay aaltay merged commit 50c5281 into apache:master Oct 4, 2019
@aaltay
Copy link
Member

aaltay commented Oct 4, 2019

OK. Merged this, please do the clean up as soon as possible.

@davidcavazos davidcavazos deleted the normalize-filenames branch October 6, 2019 22:59
@davidcavazos davidcavazos restored the normalize-filenames branch October 7, 2019 09:13
@davidcavazos davidcavazos deleted the normalize-filenames branch October 7, 2019 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants