Skip to content

[BEAM-8358] Fixes the failing test issue in UTC+8 timezone#9736

Closed
zkauker wants to merge 1 commit intoapache:masterfrom
zkauker:BEAM-8358
Closed

[BEAM-8358] Fixes the failing test issue in UTC+8 timezone#9736
zkauker wants to merge 1 commit intoapache:masterfrom
zkauker:BEAM-8358

Conversation

@zkauker
Copy link

@zkauker zkauker commented Oct 7, 2019

The date converter converted the UTC timestamp to ZonedDateTime first and then truncated the timestamp to date. With the timestamp in the unit test, this led to the expected date + 1 day in UTC+8 timezone.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- Build Status --- --- Build Status
Java Build Status Build Status Build Status Build Status
Build Status
Build Status
Build Status Build Status Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status
--- Build Status
Build Status
Build Status
Build Status
--- --- Build Status
XLang --- --- --- Build Status --- --- ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status
Build Status
Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

@zkauker
Copy link
Author

zkauker commented Oct 7, 2019

R: @reuvenlax
R: @iemejia
R: @JawadHyder
R: @lukecwik

@lukecwik
Copy link
Member

Is there a way you could add a test for this?

@stale
Copy link

stale bot commented Dec 29, 2019

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.

@stale stale bot added the stale label Dec 29, 2019
@stale
Copy link

stale bot commented Jan 6, 2020

This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

@stale stale bot closed this Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants