[BEAM-7389] Show code snippet outputs as stdout #9790
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaltay
reviewed
Oct 14, 2019
sdks/python/apache_beam/examples/snippets/transforms/elementwise/filter_test.py
Outdated
Show resolved
Hide resolved
sdks/python/apache_beam/examples/snippets/transforms/elementwise/filter_test.py
Outdated
Show resolved
Hide resolved
davidcavazos
force-pushed
the
snippets-stdout-outputs
branch
3 times, most recently
from
4abb610 to
70271b0
Compare
davidcavazos
force-pushed
the
snippets-stdout-outputs
branch
from
70271b0 to
879a67a
Compare
Author
|
Added a wrapper function to correctly handle UTF-8 strings as well as Python objects/dictionaries from stdout in both Python 2 and 3. |
Author
|
@aaltay This is ready for review |
aaltay
approved these changes
Oct 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was a little confusing to see the outputs of the code as lists rather than what actually outputs when running the code.
Changing the outputs of the code snippets to what we actually see when running the code, this makes it consistent with the outputs of the notebooks as well.
It's mostly adding some logic to "parse" the stdout outputs, but the logic of the code samples stays the same.
I did some style changes to the
Partitionsamples to make them easier to read as well.R: @aaltay
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.