[BEAM-8609] Add HllCount to Java transform catalog#9793
Merged
boyuanzz merged 1 commit intoapache:masterfrom Nov 11, 2019
Merged
[BEAM-8609] Add HllCount to Java transform catalog#9793boyuanzz merged 1 commit intoapache:masterfrom
boyuanzz merged 1 commit intoapache:masterfrom
Conversation
zfraa
reviewed
Oct 16, 2019
zfraa
left a comment
zfraa
left a comment
There was a problem hiding this comment.
Sorry lots of comments ;) looks good overall!
website/src/documentation/transforms/java/aggregation/hllcount.md
Outdated
Show resolved
Hide resolved
website/src/documentation/transforms/java/aggregation/hllcount.md
Outdated
Show resolved
Hide resolved
website/src/documentation/transforms/java/aggregation/hllcount.md
Outdated
Show resolved
Hide resolved
website/src/documentation/transforms/java/aggregation/hllcount.md
Outdated
Show resolved
Hide resolved
website/src/documentation/transforms/java/aggregation/hllcount.md
Outdated
Show resolved
Hide resolved
website/src/documentation/transforms/java/aggregation/hllcount.md
Outdated
Show resolved
Hide resolved
website/src/documentation/transforms/java/aggregation/hllcount.md
Outdated
Show resolved
Hide resolved
website/src/documentation/transforms/java/aggregation/hllcount.md
Outdated
Show resolved
Hide resolved
soyrice
reviewed
Oct 21, 2019
website/src/documentation/transforms/java/aggregation/hllcount.md
Outdated
Show resolved
Hide resolved
Contributor
|
Thanks Robin, this looks great. I'll take another look after implementing Andrea and Ryan's suggestions |
zfraa
approved these changes
Nov 4, 2019
zfraa
left a comment
zfraa
left a comment
There was a problem hiding this comment.
Looks great, thank you for your work on this!
website/src/documentation/transforms/java/aggregation/hllcount.md
Outdated
Show resolved
Hide resolved
website/src/documentation/transforms/java/aggregation/hllcount.md
Outdated
Show resolved
Hide resolved
website/src/documentation/transforms/java/aggregation/hllcount.md
Outdated
Show resolved
Hide resolved
soyrice
approved these changes
Nov 5, 2019
Contributor
soyrice
left a comment
soyrice
left a comment
There was a problem hiding this comment.
A few minor/nit comments but otherwise LGTM
website/src/documentation/transforms/java/aggregation/hllcount.md
Outdated
Show resolved
Hide resolved
website/src/documentation/transforms/java/aggregation/hllcount.md
Outdated
Show resolved
Hide resolved
website/src/documentation/transforms/java/aggregation/hllcount.md
Outdated
Show resolved
Hide resolved
Contributor
Author
|
All comments have been resolved. I think this PR is ready to merge now. |
robinyqiu
changed the title
robinyqiu
changed the title
robinyqiu
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r: @soyrice @zfraa
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.