[BEAM-8418] Use base64 string for representing impulse payload in DF runner legacy codepath.#9822
Merged
tvalentyn merged 2 commits intoapache:masterfrom Oct 22, 2019
Conversation
tvalentyn
force-pushed
the
BEAM-8418-correct-impulse-representation
branch
2 times, most recently
from
48a4a51 to
6257da8
Compare
tvalentyn
force-pushed
the
BEAM-8418-correct-impulse-representation
branch
from
6257da8 to
250ab6f
Compare
Contributor
Author
|
Run Python Dataflow ValidatesRunner |
Contributor
Author
|
Run Python PreCommit |
Contributor
Author
|
Run Python 3.6 PostCommit |
Contributor
Author
|
R: @robertwb |
robertwb
approved these changes
Oct 22, 2019
Contributor
robertwb
left a comment
robertwb
left a comment
There was a problem hiding this comment.
This is unfortunate, but fortunately can be deleted when the non-fn-api path goes away.
Contributor
Author
|
I am not sure why we chose URL encoding in FnAPI codepath, since base64 may be better suited for binary data. Feel free to add any thoughts on that to BEAM-8418 or close it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.