feat(starter): support configurable multi-dimensional metricsTags (Part of #243)#245
Merged
popduke merged 2 commits intoapache:mainfrom Apr 23, 2026
Merged
feat(starter): support configurable multi-dimensional metricsTags (Part of #243)#245popduke merged 2 commits intoapache:mainfrom
popduke merged 2 commits intoapache:mainfrom
Conversation
- Add metricsTags config option to define multiple global labels in standalone.yml - Keep clusterConfig.env as default metricsTags to ensure backward compatibility - Add clusterEnv tag to base-cluster Messenger and TCPTransport metrics - Include clusterEnv in AgentHost member list tags BREAKING CHANGE: Global metrics now use metricsTags config instead of single clusterConfig.env injection. To migrate, move the original env value to metricsTags config. Example config: metricsTags: region: gz deployment: canary env: Test
popduke
force-pushed
the
feature/243-phase-1
branch
from
709c0db to
c9c2ccc
Compare
popduke
reviewed
Apr 21, 2026
Contributor
popduke
left a comment
popduke
left a comment
There was a problem hiding this comment.
LGTM, what do u think? @Gujiawei-Edinburgh
Contributor
Looks good. But one thing I am confused is the precedence handling mentioned in issue. From current changes, it is more like injecting env to low level tags. |
popduke
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Global metrics now use metricsTags config instead of single clusterConfig.env injection. To migrate, move the original env value to metricsTags config.
Example config: