Skip to content

Conversation

@iwasakims
Copy link
Member

https://issues.apache.org/jira/browse/BIGTOP-4101

BIGTOP-4097 broke the manifest in openEuler due to missing pkgs variable.

@iwasakims iwasakims requested a review from sekikn April 30, 2024 07:56
@iwasakims
Copy link
Member Author

@sekikn Could you review this? I need to fix this to move Bigtop 3.3.0 release forward.

@iwasakims iwasakims requested a review from kevinw66 May 14, 2024 06:46
@kevinw66
Copy link
Contributor

Before:

[root@localhost bigtop]# ./gradlew -POS=openeuler-22.03 -Pprefix=3.3.0 bigtop-slaves
......

#7 [3/5] RUN if [ -f ~/.bash_profile ]; then . ~/.bash_profile; fi &&     yum clean all && yum updateinfo &&     puppet apply -e "include bigtop_toolchain::installer" --modulepath=/etc/puppet/modules/ || if [ $? -ne 2 ]; then exit 1; fi
#7 0.876 50 files removed
#7 85.89 OS                                               41 kB/s | 3.4 MB     01:24    
#7 435.4 everything                                       49 kB/s |  17 MB     05:48    
#7 440.4 EPOL                                            2.5 MB/s | 4.7 MB     00:01    
#7 545.0 debuginfo                                        40 kB/s | 4.0 MB     01:43    
#7 593.0 source                                           39 kB/s | 1.8 MB     00:47    
#7 601.9 update                                          1.8 MB/s |  15 MB     00:08    
#7 617.2 update-source                                    34 kB/s | 420 kB     00:12    
#7 618.6 Updates Information Summary: available
#7 618.6     15 Security notice(s)
#7 618.6          6 Important Security notice(s)
#7 618.6          7 Moderate Security notice(s)
#7 618.6          2 Low Security notice(s)
#7 643.1 Warning: Unknown variable: 'pkgs'. (file: /etc/puppet/modules/bigtop_toolchain/manifests/renv.pp, line: 54, column: 13)
#7 643.1 Error: Evaluation Error: Missing title. The title expression resulted in undef (file: /etc/puppet/modules/bigtop_toolchain/manifests/renv.pp, line: 54, column: 13) on node buildkitsandbox

After:

[root@localhost bigtop]# ./gradlew -POS=openeuler-22.03 -Pprefix=3.3.0 bigtop-slaves
......
#10 exporting to image
#10 exporting layers
#10 exporting layers 18.0s done
#10 writing image sha256:327660eb69db4e8aa90a9fe4138d1857da82b6f08271c52479558fc17495fe81 done
#10 naming to docker.io/bigtop/slaves:3.3.0-openeuler-22.03 done
#10 DONE 18.0s
+ rm -f Dockerfile

BUILD SUCCESSFUL in 2m 56s
1 actionable task: 1 executed

Copy link
Contributor

@kevinw66 kevinw66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM, thanks @iwasakims

@kevinw66 kevinw66 merged commit b106497 into apache:master May 14, 2024
kevinw66 pushed a commit to kevinw66/bigtop that referenced this pull request May 14, 2024
kevinw66 pushed a commit to kevinw66/bigtop that referenced this pull request May 14, 2024
@iwasakims
Copy link
Member Author

Thanks, @kevinw66.

kevinw66 pushed a commit to kevinw66/bigtop that referenced this pull request May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants