Skip to content

BIGTOP-2878 : Download task does not work for git repositories#282

Closed
zenmyo wants to merge 1 commit intoapache:masterfrom
zenmyo:BIGTOP-2878
Closed

BIGTOP-2878 : Download task does not work for git repositories#282
zenmyo wants to merge 1 commit intoapache:masterfrom
zenmyo:BIGTOP-2878

Conversation

@zenmyo
Copy link
Copy Markdown
Contributor

@zenmyo zenmyo commented Sep 5, 2017

No description provided.

def final GIT_ACCESS_TOKEN = config.bigtop.components[target].git.token ?: config.bigtop.git.token

if (!DOWNLOAD_URL)
if (!DOWNLOAD_URL && !(GIT_REPO && GIT_REF))
Copy link
Copy Markdown

@ghost ghost Sep 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!
Took me a while to get the full picture, and I even had to write a small test to see the truth matrix

#!/usr/bin/env groovy

def final BOOLS = [false, true]
for (DOWNLOAD_URL in BOOLS)
  for (GIT_REPO in BOOLS)
    for (GIT_REF in BOOLS) {
      println("$DOWNLOAD_URL $GIT_REPO $GIT_REF")
      println ("\t\t ${(!DOWNLOAD_URL && !(GIT_REPO && GIT_REF)).toString().toUpperCase()}")
    }

but everything worked out just fine.
+1 will commit it shortly

@asfgit asfgit closed this in a9c37bd Sep 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant