Skip to content

BIGTOP-3364: Leverage pip3/python3 to install setuptools#646

Merged
JunHe77 merged 1 commit intoapache:masterfrom
guyuqi:BIGTOP-3364
Jun 23, 2020
Merged

BIGTOP-3364: Leverage pip3/python3 to install setuptools#646
JunHe77 merged 1 commit intoapache:masterfrom
guyuqi:BIGTOP-3364

Conversation

@guyuqi
Copy link
Member

@guyuqi guyuqi commented Jun 15, 2020

setuptools could not be installed by pip/pip2 on Ubuntu-16.04/18.04 and centos-7.
From https://packaging.python.org/tutorials/installing-packages/#requirements-for-installing-packages, it suggests to leverage python3/pip3 to install setuptools package.

setuptools could not be installed by pip/pip2 on Ubuntu-16.04/18.04 and centos-7.
From https://packaging.python.org/tutorials/installing-packages/#requirements-for-installing-packages,
it suggests to leverage python3/pip3 to install setuptools package.

Change-Id: I42b6eb483d3f0e66637e6fc6bbd1fa6eb0a4e60c
Signed-off-by: Yuqi Gu <yuqi.gu@arm.com>
@sekikn
Copy link
Contributor

sekikn commented Jun 16, 2020

+1, I confirmed that your PR works at least for CentOS 7 and 8, and Ubuntu 18.04 on an x86_64 machine, using ./gradlew toolchain zeppelin-pkg -Dbuildwithdeps=true. I'm also running the same command now on Debian 9 and 10, and Ubuntu 16.04 and it seems to work.
So go ahead and merge if you've already confirmed that it also works on aarch64 :)

@JunHe77
Copy link
Contributor

JunHe77 commented Jun 23, 2020

Merged. Thanks for the patch, @guyuqi .

@JunHe77 JunHe77 merged commit 34e0bd7 into apache:master Jun 23, 2020
@evans-ye
Copy link
Contributor

LGTM. +1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants