BIGTOP-3371. Unable to build Apache Ambari on RHEL8. #656
Conversation
| - ts = rpm.TransactionSet() | ||
| - packages = ts.dbMatch() | ||
| + import os | ||
| + packages = os.popen("rpm -qa --queryformat '%{name} '").read().split() |
There was a problem hiding this comment.
packages variable should contain a dict-like object as this is used like this ?
There was a problem hiding this comment.
That's right, thanks! I fixed the succeeding for-loop.
|
@sekikn Thanks for working on this! I haven't tested this patch yet, but it looks good except for one point. |
iwasakims
left a comment
iwasakims
left a comment
There was a problem hiding this comment.
LGTM. ./gradlew toolchain, ./gradlew ambari-rpm and sudo yum install ambari-server worked for both CentOS 7 and CentOS 8 with the patch.
|
LGTM (non-binding). I also built ( |
|
Thank you for the review @masatana @iwasakims, just merged. |
3 participants
@guyuqi @mattAndruff @masatana Would you review if possible? In this PR, I intended:
rpmcommandpythoncommand as an alias ofpython2on CentOS 8 and Fedora 31, which don't provide unversioned python command by defaultI confirmed that Ambari, Livy and Zeppelin (the latter of two use Python3, in contrast to Ambari) are successfully built on CentOS 7, 8 and Fedora 31 with this PR.