Skip to content

BIGTOP-3398. Fix GPDB puppet manifest to work.#668

Merged
iwasakims merged 2 commits intoapache:masterfrom
sekikn:BIGTOP-3398
Sep 8, 2020
Merged

BIGTOP-3398. Fix GPDB puppet manifest to work.#668
iwasakims merged 2 commits intoapache:masterfrom
sekikn:BIGTOP-3398

Conversation

@sekikn
Copy link
Copy Markdown
Contributor

@sekikn sekikn commented Sep 7, 2020

Tested on all target distros.

@guyuqi
Copy link
Copy Markdown
Member

guyuqi commented Sep 7, 2020

+1

@iwasakims
Copy link
Copy Markdown
Member

@sekikn I got error on CentOS 8. The cause seems to be hard coded OS version in the URL of epel. Can we fix this here?
https://github.com/apache/bigtop/blob/master/bigtop-deploy/puppet/modules/gpdb/manifests/init.pp#L100

@sekikn
Copy link
Copy Markdown
Contributor Author

sekikn commented Sep 8, 2020

@guyuqi Thank you for reviewing!
@iwasakims Thank you for catching this, I'll update the PR.

@sekikn
Copy link
Copy Markdown
Contributor Author

sekikn commented Sep 8, 2020

Updated the PR, tested on CentOS 7 and 8.

Copy link
Copy Markdown
Member

@iwasakims iwasakims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. Thanks, @sekikn.

@iwasakims iwasakims merged commit 6118913 into apache:master Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants