Skip to content

BIGTOP-3548: Hive build failure caused by protoc-jar-maven-plugin mis…#781

Merged
iwasakims merged 1 commit intoapache:masterfrom
JunHe77:BIGTOP-3548
Jun 5, 2021
Merged

BIGTOP-3548: Hive build failure caused by protoc-jar-maven-plugin mis…#781
iwasakims merged 1 commit intoapache:masterfrom
JunHe77:BIGTOP-3548

Conversation

@JunHe77
Copy link
Contributor

@JunHe77 JunHe77 commented Jun 2, 2021

…sing aarch64 support

Hive uses protoc-jar to provide protoc executable to
process *.proto files. The protoc-jar-maven-plugin-2.5.0
doesn't include non-x86 binaries which caused build
failure on non-x86 platforms.
Backport HIVE-21939 to 3.1.2 branch and added ppc64le support.

Change-Id: I14f9ce54272a3eda1557710ab4276d999eed4a57
Signed-off-by: Jun He jun.he@arm.com

…sing aarch64 support

Hive uses protoc-jar to provide protoc executable to
process *.proto files. The protoc-jar-maven-plugin-2.5.0
doesn't include non-x86 binaries which caused build
failure on non-x86 platforms.
Backport HIVE-21939 to 3.1.2 branch.

Change-Id: I14f9ce54272a3eda1557710ab4276d999eed4a57
Signed-off-by: Jun He <jun.he@arm.com>
Copy link
Member

@iwasakims iwasakims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. ./gradlew hive-pkg and smoke tests of hive on docker provisioned container worked for me on trunk-ubuntu-18.04-aarch64 and trunk-centos-8 (x86_64). Thanks, @JunHe77.

@iwasakims
Copy link
Member

I don't have local environment for testing ppc64le. I'm expecting the fix to work on ci.bigtop.apache.org.

@iwasakims iwasakims merged commit 0cabb07 into apache:master Jun 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants