BIGTOP-3635: Bump logstash's log4j dependencies to 2.17.0#858
Merged
Conversation
dependencies on old log4j2
iwasakims
approved these changes
Jan 26, 2022
Member
iwasakims
left a comment
iwasakims
left a comment
There was a problem hiding this comment.
LGTM. smoke-tests passed on CentOS 7 x86_64.
$ ./gradlew logstash-clean logstash-pkg repo
$ rpm -qlp output/logstash/x86_64/logstash-5.4.1-2.el7.x86_64.rpm | grep -i log4j
/etc/logstash/conf.dist/log4j2.properties
/usr/lib/logstash/logstash-core/lib/org/apache/logging/log4j
/usr/lib/logstash/logstash-core/lib/org/apache/logging/log4j/log4j-api
/usr/lib/logstash/logstash-core/lib/org/apache/logging/log4j/log4j-api/2.17.0
/usr/lib/logstash/logstash-core/lib/org/apache/logging/log4j/log4j-api/2.17.0/log4j-api-2.17.0.jar
/usr/lib/logstash/logstash-core/lib/org/apache/logging/log4j/log4j-core
/usr/lib/logstash/logstash-core/lib/org/apache/logging/log4j/log4j-core/2.17.0
/usr/lib/logstash/logstash-core/lib/org/apache/logging/log4j/log4j-core/2.17.0/log4j-core-2.17.0.jar
$ cd provisioner/docker
$ ./docker-hadoop.sh \
--create 1 \
--image bigtop/puppet:trunk-centos-7 \
--memory 16g \
--enable-local-repo \
--disable-gpg-check \
--stack logstash \
--smoke-tests logstash
...
Now testing...
:bigtop-tests:smoke-tests:logstash:test (Thread[Execution worker for ':' Thread 4,5,main]) completed. Took 14.174 secs.
BUILD SUCCESSFUL in 46s
34 actionable tasks: 7 executed, 27 up-to-date
$ ./docker-hadoop.sh --exec 1 rpm -ql logstash | grep -i log4j
/etc/logstash/conf.dist/log4j2.properties
/usr/lib/logstash/logstash-core/lib/org/apache/logging/log4j
/usr/lib/logstash/logstash-core/lib/org/apache/logging/log4j/log4j-api
/usr/lib/logstash/logstash-core/lib/org/apache/logging/log4j/log4j-api/2.17.0
/usr/lib/logstash/logstash-core/lib/org/apache/logging/log4j/log4j-api/2.17.0/log4j-api-2.17.0.jar
/usr/lib/logstash/logstash-core/lib/org/apache/logging/log4j/log4j-core
/usr/lib/logstash/logstash-core/lib/org/apache/logging/log4j/log4j-core/2.17.0
/usr/lib/logstash/logstash-core/lib/org/apache/logging/log4j/log4j-core/2.17.0/log4j-core-2.17.0.jar
Member
|
looks good on Ubuntu 20.04 too. |
iwasakims
pushed a commit
that referenced
this pull request
Jan 26, 2022
(cherry picked from commit d723c1b)
Member
|
I merged this to master and branch-3.0. Thanks, @yoda-mon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update log4j2 version to 2.17.0 to keep up the issue https://issues.apache.org/jira/browse/BIGTOP-3613.
This PR omits default plugins
that includes older versions of log4j.
Those plugins do not seem to be maintained now so I would rather remove them than make efforts to path those plugins.