Skip to content

BookieRequestHandler should provide remote address when catch exception #2475

@aloyszhang

Description

@aloyszhang

BUG REPORT

Describe the bug
Currently, BookieRequestHandler only provides exception cause when catching exceptions. I think it's better to also log the remote address, since it's helpful for trouble shooting if bookie have lots of connections.

Additional context
For now ,we can only know there is somthing wrong with one connection to bookie, but can not konw which connection .

2020-11-02 22:49:44,725 - ERROR [bookie-io-1-12:BookieRequestHandler@70] - Unhandled exception occurred in I/O thread or handler
io.netty.channel.unix.Errors$NativeIoException: writevAddresses(..) failed: Connection reset by peer
        at io.netty.channel.unix.Errors.newIOException(Errors.java:122)
        at io.netty.channel.unix.Errors.ioResult(Errors.java:146)
        at io.netty.channel.unix.FileDescriptor.writevAddresses(FileDescriptor.java:155)
        at io.netty.channel.epoll.AbstractEpollStreamChannel.writeBytesMultiple(AbstractEpollStreamChannel.java:316)
        at io.netty.channel.epoll.AbstractEpollStreamChannel.doWriteMultiple(AbstractEpollStreamChannel.java:522)
        at io.netty.channel.epoll.AbstractEpollStreamChannel.doWrite(AbstractEpollStreamChannel.java:434)
        at io.netty.channel.AbstractChannel$AbstractUnsafe.flush0(AbstractChannel.java:938)
        at io.netty.channel.epoll.AbstractEpollChannel$AbstractEpollUnsafe.epollOutReady(AbstractEpollChannel.java:525)
        at io.netty.channel.epoll.EpollEventLoop.processReady(EpollEventLoop.java:423)
        at io.netty.channel.epoll.EpollEventLoop.run(EpollEventLoop.java:330)
        at io.netty.util.concurrent.SingleThreadEventExecutor$5.run(SingleThreadEventExecutor.java:909)
        at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
        at java.lang.Thread.run(Thread.java:748)

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions