Test that old clients work with current server#1083
Closed
ivankelly wants to merge 2 commits intoapache:masterfrom
Closed
Test that old clients work with current server#1083ivankelly wants to merge 2 commits intoapache:masterfrom
ivankelly wants to merge 2 commits intoapache:masterfrom
Conversation
Test that old clients(4.2.0 onwards) can create, open, read, write ledgers on the latest version of the server. Master Issue: apache#903
Contributor
Author
|
retest this please |
eolivelli
requested changes
Jan 30, 2018
| // 4.1.0 doesn't work because metadata format changed | ||
| private def oldClientVersions = ["4.2.0", "4.2.1", "4.2.2", "4.2.3", "4.2.4", | ||
| "4.3.0", "4.3.1", "4.3.2", "4.4.0", "4.5.0", "4.5.1", | ||
| "4.6.0"] |
Contributor
There was a problem hiding this comment.
We can add 4.6.1 before committing this patch eventually
| ledger0.addEntry("shouldn't work".getBytes()) | ||
| Assert.fail("Shouldn't have been able to add any more") | ||
| } catch (Exception e) { | ||
| // correct behaviour |
Contributor
There was a problem hiding this comment.
Here the error code is 'client closed' we should add some assertion.
But we are not testing 'fencing', or I am missing something?
sijie
approved these changes
Jan 30, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test that old clients(4.2.0 onwards) can create, open, read, write ledgers on
the latest version of the server.
Master Issue: #903