Allow default methods in MavenClassloader callbacks#1187
Closed
ivankelly wants to merge 2 commits into
Closed
Conversation
AsyncCallback.AddCallback has recently acquired a default method, which breaks the assumption that there is only one method on these callbacks. However, if does have a default method that calls the one method. This patch takes advantage of that to allow us to use AddCallback in tests.
Contributor
Author
|
This is the last change needed before I push the yahoo BC test |
Contributor
Author
|
retest this please failure was in BookieWriteLedgerTest/testLedgerCreateAdvWithLedgerIdInLoop in both cases, due to this being a very slow test and it running twice on the same machine at the same time :/ looking into it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AsyncCallback.AddCallback has recently acquired a default method,
which breaks the assumption that there is only one method on these
callbacks. However, if does have a default method that calls the one
method. This patch takes advantage of that to allow us to use
AddCallback in tests.