Always reset interrupted state after catching InterruptedException#1189
Closed
ivankelly wants to merge 1 commit into
Closed
Always reset interrupted state after catching InterruptedException#1189ivankelly wants to merge 1 commit into
ivankelly wants to merge 1 commit into
Conversation
There's many places we did not do it. I've added it.
Contributor
|
Is this a general cleanup patch or did you fall into some real problem? |
Contributor
Author
|
General cleanup, though some of the CI stuff I've been fighting was threads seeming to ignore being interrupted, which could be related. |
eolivelli
approved these changes
Feb 20, 2018
Contributor
eolivelli
left a comment
eolivelli
left a comment
There was a problem hiding this comment.
I have run thru the diff. The change is big but looks good to me
sijie
approved these changes
Feb 20, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's many places we did not do it. I've added it.