Issue #1195 Handle optional fields gracefully in ReadExplicitLac response#1196
Closed
jvrao wants to merge 3 commits into
Closed
Issue #1195 Handle optional fields gracefully in ReadExplicitLac response#1196jvrao wants to merge 3 commits into
jvrao wants to merge 3 commits into
Conversation
…c response ExplicitLac and header of the last entry are optional fields in the protocol. Handle them as optionals in the response processing. TestPendingReadLacOp.java test added by: Samuel Just <sjust@salesforce.com> Signed-off-by: Venkateswararao Jujjuri (JV) <vjujjuri@salesforce.com> Signed-off-by: Samuel Just <sjust@salesforce.com>
sijie
approved these changes
Feb 22, 2018
sijie
changed the title
Member
|
@jvrao these two checkstyle violations need to be addressed. |
Signed-off-by: Venkateswararao Jujjuri (JV) <vjujjuri@salesforce.com>
Member
|
It seems oraclejdk9 is complaining https://travis-ci.org/apache/bookkeeper/jobs/345375922 |
sijie
reviewed
Feb 23, 2018
| @Override | ||
| public void initiate() { | ||
| for (int i = 0; i < lh.metadata.currentEnsemble.size(); i++) { | ||
| final Integer index = new Integer(i); |
Member
There was a problem hiding this comment.
can you just pass "i" in readLacComplate?
sijie
pushed a commit
that referenced
this pull request
Feb 26, 2018
…onse Descriptions of the changes in this PR: ExplicitLac and header of the last entry are optional fields in the protocol. Handle them as optionals in the response processing. TestPendingReadLacOp.java test added by: Samuel Just <sjustsalesforce.com> Signed-off-by: Venkateswararao Jujjuri (JV) <vjujjurisalesforce.com> Signed-off-by: Samuel Just <sjustsalesforce.com> Master Issue: #1195 Author: JV Jujjuri <vjujjuri@salesforce.com> Author: JV <vjujjuri@salesforce.com> Reviewers: Sijie Guo <sijie@apache.org> This closes #1196 from jvrao/bk-issue-1195-lacfix, closes #1195 (cherry picked from commit 8f6373e) Signed-off-by: Sijie Guo <sijie@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Descriptions of the changes in this PR:
ExplicitLac and header of the last entry are optional fields in the protocol.
Handle them as optionals in the response processing.
TestPendingReadLacOp.java test added by: Samuel Just sjust@salesforce.com
Signed-off-by: Venkateswararao Jujjuri (JV) vjujjuri@salesforce.com
Signed-off-by: Samuel Just sjust@salesforce.com
Master Issue: #1195