Skip to content

Make shading rule consistent between bookkeeper-server-shaded and bookkeeper-server-tests-shaded#1234

Closed
sijie wants to merge 2 commits into
apache:masterfrom
sijie:sijie_improve_tests_shaded
Closed

Make shading rule consistent between bookkeeper-server-shaded and bookkeeper-server-tests-shaded#1234
sijie wants to merge 2 commits into
apache:masterfrom
sijie:sijie_improve_tests_shaded

Conversation

@sijie
Copy link
Copy Markdown
Member

@sijie sijie commented Mar 6, 2018

Descriptions of the changes in this PR:

bookkeeper-server:test-jar is working with bookkeeper-server. we should make bookkeeper-server-tests-shaded work with bookkeeper-server-shaded. so this change is to make they have consistent shading rule.

<dependency>
      <groupId>org.apache.bookkeeper</groupId>
      <artifactId>bookkeeper-server-shaded</artifactId>
      <version>${bookkeeper.version}</version>
      <scope>test</scope>
    </dependency>
<dependency>
      <groupId>org.apache.bookkeeper</groupId>
      <artifactId>bookkeeper-server-tests-shaded</artifactId>
      <version>${bookkeeper.version}</version>
      <scope>test</scope>
    </dependency>

@sijie sijie requested a review from merlimat March 6, 2018 22:32
@sijie sijie self-assigned this Mar 6, 2018
Copy link
Copy Markdown
Contributor

@merlimat merlimat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sijie sijie added this to the 4.7.0 milestone Mar 7, 2018
@sijie sijie closed this in 19846b2 Mar 7, 2018
@sijie sijie deleted the sijie_improve_tests_shaded branch July 16, 2018 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants