Issue #1405: ReplicationWorker should back-off retrying.#1406
Closed
reddycharan wants to merge 3 commits intoapache:masterfrom
Closed
Issue #1405: ReplicationWorker should back-off retrying.#1406reddycharan wants to merge 3 commits intoapache:masterfrom
reddycharan wants to merge 3 commits intoapache:masterfrom
Conversation
ReplicationWorker should backoff replication after threshold number of replication failures of a ledger. Currently ReplicationWorker will do busy retrials if replication is failed for a ledger, instead it should backoff if replication had failed for threshold number of times. This can be done by deferring releasing of underreplicated lock by 'lockReleaseOfFailedLedgerGracePeriod' amount of time.
eolivelli
reviewed
May 15, 2018
Contributor
eolivelli
left a comment
eolivelli
left a comment
There was a problem hiding this comment.
How about adding some counter? Not blocker for me
sijie
approved these changes
May 16, 2018
- relevant logs
- relevant counter
Contributor
Author
|
@eolivelli added relevant log and counter |
reddycharan
added a commit
to reddycharan/bookkeeper
that referenced
this pull request
May 21, 2018
Descriptions of the changes in this PR: ReplicationWorker should backoff replication after threshold number of replication failures of a ledger. Currently ReplicationWorker will do busy retrials if replication is failed for a ledger, instead it should backoff if replication had failed for threshold number of times. This can be done by deferring releasing of underreplicated lock by 'lockReleaseOfFailedLedgerGracePeriod' amount of time. Master Issue: apache#1405 Author: cguttapalem <cguttapalem@salesforce.com> Reviewers: Enrico Olivelli <eolivelli@gmail.com>, Jia Zhai <None>, Sijie Guo <sijie@apache.org> This closes apache#1406 from reddycharan/fixreplicator, closes apache#1405
reddycharan
added a commit
to reddycharan/bookkeeper
that referenced
this pull request
Jul 6, 2018
…f retrying. Descriptions of the changes in this PR: ReplicationWorker should backoff replication after threshold number of replication failures of a ledger. Currently ReplicationWorker will do busy retrials if replication is failed for a ledger, instead it should backoff if replication had failed for threshold number of times. This can be done by deferring releasing of underreplicated lock by 'lockReleaseOfFailedLedgerGracePeriod' amount of time. Master Issue: apache#1405 Author: cguttapalem <cguttapalem@salesforce.com> Reviewers: Enrico Olivelli <eolivelli@gmail.com>, Jia Zhai <None>, Sijie Guo <sijie@apache.org> This closes apache#1406 from reddycharan/fixreplicator, closes apache#1405
reddycharan
added a commit
to reddycharan/bookkeeper
that referenced
this pull request
Jul 9, 2018
…f retrying. Descriptions of the changes in this PR: ReplicationWorker should backoff replication after threshold number of replication failures of a ledger. Currently ReplicationWorker will do busy retrials if replication is failed for a ledger, instead it should backoff if replication had failed for threshold number of times. This can be done by deferring releasing of underreplicated lock by 'lockReleaseOfFailedLedgerGracePeriod' amount of time. Master Issue: apache#1405 Author: cguttapalem <cguttapalem@salesforce.com> Reviewers: Enrico Olivelli <eolivelli@gmail.com>, Jia Zhai <None>, Sijie Guo <sijie@apache.org> This closes apache#1406 from reddycharan/fixreplicator, closes apache#1405
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Descriptions of the changes in this PR:
ReplicationWorker should backoff replication
after threshold number of replication failures of a ledger.
Currently ReplicationWorker will do busy retrials if
replication is failed for a ledger, instead it should
backoff if replication had failed for threshold
number of times. This can be done by deferring
releasing of underreplicated lock by
'lockReleaseOfFailedLedgerGracePeriod' amount
of time.
Master Issue: #1405