Update the new bookkeeper tools to use the new framework#1478
Closed
sijie wants to merge 1 commit intoapache:masterfrom
Closed
Update the new bookkeeper tools to use the new framework#1478sijie wants to merge 1 commit intoapache:masterfrom
sijie wants to merge 1 commit intoapache:masterfrom
Conversation
*Motivation* previous PR introduces a new framework wrapping over jcommander. This PR is changing the new bookkeeper cli tools to leverage that framework. *Solution* - Changed the related classes to use the new framework At the same time, rename `BookKeeperCLI` to `BKCtl` and `bookkeeper-cli` to `bkctl` Exclude bookkeeper-tools-framework from shaded libs Rename `cluster` to `bookies`
jiazhai
approved these changes
Jun 5, 2018
sijie
added a commit
that referenced
this pull request
Jun 7, 2018
Descriptions of the changes in this PR: *Motivation* This PR follows #1478 to move table service cli to bookkeeper-tools. So different service components are now available in one cli tool. *Changes* - move stream/cli module to tools/stream module - organize the table service commands as groups: * cluster * namespace * table * tables *Output* Example output: ``` $ bin/bkctl bkctl interacts and operates Apache BookKeeper clusters Usage: bkctl [flags] [command group] [commands] Commands: bookie Commands on operating a single bookie bookies Commands on operating a cluster of bookies cluster Commands on administrating bookkeeper clusters ledger Commands on interacting with ledgers namespace Commands on operating namespaces table Commands on interacting with tables tables Commands on operating tables help Display help information about it Flags: -c, --conf Configuration file -n, --namespace Namespace scope to run commands (only valid for table service for now) -u, --service-uri Service Uri -h, --help Display help information Use "bkctl [command] --help" or "bkctl help [command]" for more information about a command ``` Author: Sijie Guo <sijie@apache.org> Reviewers: Jia Zhai <None> This closes #1485 from sijie/stream_cli
This was referenced Jun 12, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Descriptions of the changes in this PR:
Motivation
#1471 introduces a new tools framework based on jcommander. This PR is changing the new bookkeeper-tools to leverage that framework.
Solution
BookKeeperCLItoBKCtlandbookkeeper-clitobkctlclustertobookiesResults
Example output of this change:
sub command
sub-sub command