Skip to content

Fix checkstyle in EntryLogTest#1483

Closed
sijie wants to merge 3 commits intoapache:masterfrom
sijie:fix_checkstyle_complains_entrylogtest
Closed

Fix checkstyle in EntryLogTest#1483
sijie wants to merge 3 commits intoapache:masterfrom
sijie:fix_checkstyle_complains_entrylogtest

Conversation

@sijie
Copy link
Copy Markdown
Member

@sijie sijie commented Jun 5, 2018

Descriptions of the changes in this PR:

Problem

PR #1465 introduces a checkstyle error, but somehow it wasn't caught by CI jobs.

Solution

Fix the checkstyle error and bring master back to normal.

*Problem*

PR apache#1465 introduces a checkstyle error, but somehow it wasn't caught by CI jobs.

*Solution*

Fix the checkstyle error and bring master back to normal.
@sijie
Copy link
Copy Markdown
Member Author

sijie commented Jun 5, 2018

@reddycharan can you review this?

@reddycharan
Copy link
Copy Markdown
Contributor

LGTM!

@sijie
Copy link
Copy Markdown
Member Author

sijie commented Jun 5, 2018

run pr validation

@sijie
Copy link
Copy Markdown
Member Author

sijie commented Jun 6, 2018

run pr validation

@sijie
Copy link
Copy Markdown
Member Author

sijie commented Jun 6, 2018

pr validation passed.

@sijie
Copy link
Copy Markdown
Member Author

sijie commented Jun 6, 2018

IGNORE CI

@sijie sijie added this to the 4.8.0 milestone Jun 6, 2018
@sijie sijie self-assigned this Jun 6, 2018
@sijie sijie closed this in 9a0bf5a Jun 6, 2018
@sijie sijie deleted the fix_checkstyle_complains_entrylogtest branch July 16, 2018 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants