autorecovery-use-metadata-driver (part 4) : provide an AuditorSelector interface to abstract leader election logic for AuditorElector
#1701
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,78 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.bookkeeper.meta; | ||
|
|
||
| import java.io.IOException; | ||
| import java.util.concurrent.Future; | ||
| import org.apache.bookkeeper.meta.exceptions.MetadataException; | ||
| import org.apache.bookkeeper.net.BookieSocketAddress; | ||
|
|
||
| /** | ||
| * Interface for selecting an auditor. | ||
| */ | ||
| public interface AuditorSelector extends AutoCloseable { | ||
|
Contributor
There was a problem hiding this comment. After reviewing the whole patch I suggest calling this interface 'AuditorElectionManager' |
||
|
|
||
| /** | ||
| * Selector listener to listen on auditor changes. | ||
| */ | ||
| interface SelectorListener { | ||
|
|
||
| /** | ||
| * Trigger when it is selected as a leader. | ||
| */ | ||
| void onLeaderSelected() throws IOException; | ||
|
Contributor
There was a problem hiding this comment. Better 'election' over 'selection'
Contributor
Author
There was a problem hiding this comment. there is already and selector is pretty standard in curator : https://curator.apache.org/curator-recipes/leader-election.html |
||
|
|
||
| /** | ||
| * Trigger on each selection attempt. | ||
| */ | ||
| void onSelectionAttempt(); | ||
|
|
||
| /** | ||
| * Trigger when it lost its leadership. | ||
| */ | ||
| void onLeaderExpired(); | ||
|
|
||
| } | ||
|
|
||
| /** | ||
| * Whether the selector is running or not. | ||
| * | ||
| * @return true if the selector is running, otherwise false. | ||
| */ | ||
| boolean isRunning(); | ||
|
|
||
| /** | ||
| * Trigger the selecting process with the provided <tt>listener</tt>. | ||
|
|
||
| * | ||
| * @param listener the listener to listen on events triggered by selection. | ||
| * @return a future when the selector is running | ||
| */ | ||
| Future<?> select(SelectorListener listener) | ||
| throws MetadataException; | ||
|
|
||
| /** | ||
| * Get the current auditor. | ||
| * | ||
| * @return current auditor. | ||
| */ | ||
| BookieSocketAddress getCurrentAuditor() throws MetadataException; | ||
|
|
||
| @Override | ||
| void close(); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.bookkeeper.meta.exceptions; | ||
|
|
||
| /** | ||
| * Metadata Runtime Exception. | ||
| */ | ||
| public class MetadataRuntimeException extends RuntimeException { | ||
|
|
||
| private static final long serialVersionUID = -7833758146152388503L; | ||
|
|
||
| private final Code code; | ||
|
|
||
| public MetadataRuntimeException(Code code, String message) { | ||
| super(message); | ||
| this.code = code; | ||
| } | ||
|
|
||
| public MetadataRuntimeException(Code code, String message, Throwable cause) { | ||
| super(message, cause); | ||
| this.code = code; | ||
| } | ||
|
|
||
| public MetadataRuntimeException(Code code, Throwable cause) { | ||
| super(cause); | ||
| this.code = code; | ||
| } | ||
|
|
||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -96,6 +96,7 @@ public void close() { | |
| if (null != rmToClose) { | ||
| rmToClose.close(); | ||
| } | ||
|
|
||
| super.close(); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it better give a name to the thread?