Skip to content

[table service][client] provide scripts for uploading python clients to pypi#1734

Merged
sijie merged 3 commits intoapache:masterfrom
sijie:upload_python_client
Oct 4, 2018
Merged

[table service][client] provide scripts for uploading python clients to pypi#1734
sijie merged 3 commits intoapache:masterfrom
sijie:upload_python_client

Conversation

@sijie
Copy link
Member

@sijie sijie commented Oct 3, 2018

Descriptions of the changes in this PR:

Motivation

make the python client available for usage

Changes

  • update README and setup.py
  • set the client version to 4.9.0-alpha-0
  • scripts to build python client and upload it to pypi

Result

https://pypi.org/project/apache-bookkeeper-client/4.9.0a0/


In order to uphold a high standard for quality for code contributions, Apache BookKeeper runs various precommit
checks for pull requests. A pull request can only be merged when it passes precommit checks. However running all
the precommit checks can take a long time, some trivial changes don't need to run all the precommit checks. You
can check following list to skip the tests that don't need to run for your pull request. Leave them unchecked if
you are not sure, committers will help you:

  • [skip bookkeeper-server bookie tests]: skip testing org.apache.bookkeeper.bookie in bookkeeper-server module.
  • [skip bookkeeper-server client tests]: skip testing org.apache.bookkeeper.client in bookkeeper-server module.
  • [skip bookkeeper-server replication tests]: skip testing org.apache.bookkeeper.replication in bookkeeper-server module.
  • [skip bookkeeper-server tls tests]: skip testing org.apache.bookkeeper.tls in bookkeeper-server module.
  • [skip bookkeeper-server remaining tests]: skip testing all other tests in bookkeeper-server module.
  • [skip integration tests]: skip docker based integration tests. if you make java code changes, you shouldn't skip integration tests.
  • [skip build java8]: skip build on java8. ONLY skip this when ONLY changing files under documentation under site.
  • [skip build java9]: skip build on java9. ONLY skip this when ONLY changing files under documentation under site.


Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

If this PR is a BookKeeper Proposal (BP):

  • Make sure the PR title is formatted like:
    <BP-#>: Description of bookkeeper proposal
    e.g. BP-1: 64 bits ledger is support
  • Attach the master issue link in the description of this PR.
  • Attach the google doc link if the BP is written in Google Doc.

Otherwise:

  • Make sure the PR title is formatted like:
    <Issue #>: Description of pull request
    e.g. Issue 123: Description ...
  • Make sure tests pass via mvn clean apache-rat:check install spotbugs:check.
  • Replace <Issue #> in the title with the actual Issue number.

sijie added 2 commits October 3, 2018 10:51
…to pypi

*Motivation*

make the python client available for usage

*Changes*

- update README and setup.py
- set the client version to `4.9.0-alpha-0`
- scripts to build python client and upload it to pypi

*Result*

https://pypi.org/project/apache-bookkeeper-client/4.9.0a0/
@sijie sijie added type/task area/tableservice changes related to table service release/4.9.0 labels Oct 3, 2018
@sijie sijie added this to the 4.9.0 milestone Oct 3, 2018
@sijie sijie self-assigned this Oct 3, 2018
@sijie sijie requested review from jiazhai and merlimat October 3, 2018 20:25
@eolivelli
Copy link
Contributor

Do we need a formal 'release' process in order to publish this artifacts?
I think so.

@sijie
Copy link
Member Author

sijie commented Oct 3, 2018

@eolivelli yes this would be incorporated into formal release. currently the version is marked as 4.9.0-alpha-0, so it is a pre-release. so it can be used for testing purpose. when it comes to the release of 4.9.0, we will have version set to 4.9.0 and do a formal release.

Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fine with this approach, it is like we are doing with maven snapshots.
I wonder if it better to send an explicit email to dev list.
We should also start providing docs about these features

@sijie
Copy link
Member Author

sijie commented Oct 4, 2018

I wonder if it better to send an explicit email to dev list.

we can have a CI job to upload to pypi and send the email.

We should also start providing docs about these features

yes. that would be the blocker for 4.9

@sijie sijie merged commit ece38f5 into apache:master Oct 4, 2018
@sijie sijie deleted the upload_python_client branch October 4, 2018 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/tableservice changes related to table service release/4.9.0 type/task

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants