Skip to content

[table service] Fix python client can't read keys written by java clients#1771

Merged
sijie merged 4 commits into
apache:masterfrom
sijie:remove_python23_incompatible_changes
Oct 30, 2018
Merged

[table service] Fix python client can't read keys written by java clients#1771
sijie merged 4 commits into
apache:masterfrom
sijie:remove_python23_incompatible_changes

Conversation

@sijie
Copy link
Copy Markdown
Member

@sijie sijie commented Oct 30, 2018

Descriptions of the changes in this PR:

Motivation

Python client is a thin table service client. So it relies on storage container
intercepting the requests to attach routing header. It attaches the routing header
if the requests are needed to route to remote containers; however for the local containers
it doesn't attach the right routing header.

Changes

Fix StorageContainerImpl to use proxy routing interceptor to intercept requests to attach routing header.

Tests

Add integration tests in python client & add test for python clients reading key/value pairs written by java clients.


In order to uphold a high standard for quality for code contributions, Apache BookKeeper runs various precommit
checks for pull requests. A pull request can only be merged when it passes precommit checks. However running all
the precommit checks can take a long time, some trivial changes don't need to run all the precommit checks. You
can check following list to skip the tests that don't need to run for your pull request. Leave them unchecked if
you are not sure, committers will help you:

  • [skip bookkeeper-server bookie tests]: skip testing org.apache.bookkeeper.bookie in bookkeeper-server module.
  • [skip bookkeeper-server client tests]: skip testing org.apache.bookkeeper.client in bookkeeper-server module.
  • [skip bookkeeper-server replication tests]: skip testing org.apache.bookkeeper.replication in bookkeeper-server module.
  • [skip bookkeeper-server tls tests]: skip testing org.apache.bookkeeper.tls in bookkeeper-server module.
  • [skip bookkeeper-server remaining tests]: skip testing all other tests in bookkeeper-server module.
  • [skip integration tests]: skip docker based integration tests. if you make java code changes, you shouldn't skip integration tests.
  • [skip build java8]: skip build on java8. ONLY skip this when ONLY changing files under documentation under site.
  • [skip build java9]: skip build on java9. ONLY skip this when ONLY changing files under documentation under site.


Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

If this PR is a BookKeeper Proposal (BP):

  • Make sure the PR title is formatted like:
    <BP-#>: Description of bookkeeper proposal
    e.g. BP-1: 64 bits ledger is support
  • Attach the master issue link in the description of this PR.
  • Attach the google doc link if the BP is written in Google Doc.

Otherwise:

  • Make sure the PR title is formatted like:
    <Issue #>: Description of pull request
    e.g. Issue 123: Description ...
  • Make sure tests pass via mvn clean apache-rat:check install spotbugs:check.
  • Replace <Issue #> in the title with the actual Issue number.

sijie added 4 commits October 9, 2018 12:24
…ents

*Motivation*

Python client is a thin table service client. So it relies on storage container
intercepting the requests to attach routing header. It attaches the routing header
if the requests are needed to route to remote containers; however for the local containers
it doesn't attach the right routing header.

*Changes*

Fix `StorageContainerImpl` to use proxy routing interceptor to intercept requests to attach routing header.

*Tests*

Add integration tests in python client & add test for python clients reading key/value pairs written by java clients.
@sijie sijie added type/bug area/tableservice changes related to table service release/4.9.0 labels Oct 30, 2018
@sijie sijie added this to the 4.9.0 milestone Oct 30, 2018
@sijie sijie self-assigned this Oct 30, 2018
@sijie sijie requested a review from jiazhai October 30, 2018 01:51
@sijie sijie merged commit f3b8c6a into apache:master Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/tableservice changes related to table service release/4.9.0 type/bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants